Skip to content

Fix yq commit message parsing in contributions script#1457

Closed
a-hassanin wants to merge 2 commits into
cloudfoundry:mainfrom
a-hassanin:fix/contributions-yq-commit-message
Closed

Fix yq commit message parsing in contributions script#1457
a-hassanin wants to merge 2 commits into
cloudfoundry:mainfrom
a-hassanin:fix/contributions-yq-commit-message

Conversation

@a-hassanin
Copy link
Copy Markdown
Contributor

@a-hassanin a-hassanin commented Mar 23, 2026

f631f92 (Group by PR)
Refactors toc/working-groups/contributions-for-user.sh to replace flat commit listing with find_commits_grouped_by_pr_for_repo.

“Code contributions” now:

  • finds merged PRs authored by the user (search/issues ... author: is:merged)
  • prints each PR as a top-level bullet
  • fetches commits per PR and prints commit bullets under the PR only when the PR has more than one commit
  • falls back to recent PullRequestEvent merged/closed events only when search returns no merged PRs.
  • Removes sort -u from the code-contributions section so PR/commit grouping is preserved.

76bad69 (Fix yq commit message parsing in contributions script)

  • Fixes the yq expression in commit formatting from (.commit.message | split("\n")[0]) to ((.commit.message | split("\n"))[0]), avoiding the !!seq ... cannot be added to a !!str runtime error.
  • Fixes gist filename generation to use ${WORKING_GROUP} instead of ${wg} in uri_safe_file, preventing incorrect/empty filename prefixes.

@beyhan
Copy link
Copy Markdown
Member

beyhan commented May 19, 2026

@a-hassanin do you plan to work on this? I will prefer to get this resolved. Finished or close if possible.

@a-hassanin
Copy link
Copy Markdown
Contributor Author

I will close it for now and reopen once I have more time.

@a-hassanin a-hassanin closed this May 19, 2026
@github-project-automation github-project-automation Bot moved this from Inbox to Done in CF Community May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants